linux-kernel - Re: [PATCH 2/2] perf, tools, script: Add support for printing assembler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160229173528.GP5083@two.firstfloor.org>
Date:	Mon, 29 Feb 2016 18:35:28 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
	namhyung@...nel.org, Adrian Hunter <adrian.hunter@...el.com>,
	alexander.shishkin@...el.com, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/2] perf, tools, script: Add support for printing
 assembler

> What kernel have you used for testing this? 4.5-rc? I'm having trouble
> with intel_pt with 4.5.0-rc4 :-\

Works for me (on -rc5). What problem do you see?

> 
> And while this looks like a great feature to have, have you considered
> using what is in tools/perf/util/intel-pt-decoder/ somehow, so that we
> don't end up adding one more dependency on another external library?

This needs a text disassembler.

The PT decoder doesn't have a disassembler unfortunately. The kernel 
instruction decoder is also not a text disassembler. Changing it to do
that would be a quite large project. 

> It would be great if we could, if done that way, perhaps at some point
> we could stop using objdump somehow :-\

objdump does a lot of work to line up the source code correctly.
Reproducing it would be a lot of work in perf too, and need
large scales changes. Perhaps at some time, but not any time
soon.

-Andi