linux-kernel - Re: [PATCH] uprobes: wait for mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201603010150.ildJXKW1%fengguang.wu@intel.com>
Date:	Tue, 1 Mar 2016 01:52:41 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Michal Hocko <mhocko@...nel.org>
Cc:	kbuild-all@...org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>, linux-mm@...ck.org,
	Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH] uprobes: wait for mmap_sem for write killable

Hi Michal,

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.5-rc6 next-20160229]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Michal-Hocko/uprobes-wait-for-mmap_sem-for-write-killable/20160301-014513
config: i386-randconfig-x003-201609 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from kernel/events/uprobes.c:25:
   kernel/events/uprobes.c: In function 'xol_add_vma':
   kernel/events/uprobes.c:1133:6: error: implicit declaration of function 'down_write_killable' [-Werror=implicit-function-declaration]
     if (down_write_killable(&mm->mmap_sem))
         ^
   include/linux/compiler.h:147:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^
   kernel/events/uprobes.c:1133:2: note: in expansion of macro 'if'
     if (down_write_killable(&mm->mmap_sem))
     ^
   kernel/events/uprobes.c: In function 'dup_xol_work':
>> kernel/events/uprobes.c:2029:0: error: unterminated argument list invoking macro "if"
    __initcall(init_uprobes);
    ^
>> kernel/events/uprobes.c:1473:2: error: expected '(' at end of input
     if (!__create_xol_area(current->utask->dup_xol_addr) &&
     ^
>> kernel/events/uprobes.c:1473:2: error: expected declaration or statement at end of input
   kernel/events/uprobes.c: At top level:
   kernel/events/uprobes.c:961:12: warning: 'unapply_uprobe' defined but not used [-Wunused-function]
    static int unapply_uprobe(struct uprobe *uprobe, struct mm_struct *mm)
               ^
   kernel/events/uprobes.c:1293:22: warning: 'xol_get_insn_slot' defined but not used [-Wunused-function]
    static unsigned long xol_get_insn_slot(struct uprobe *uprobe)
                         ^
   kernel/events/uprobes.c:1427:28: warning: 'get_utask' defined but not used [-Wunused-function]
    static struct uprobe_task *get_utask(void)
                               ^
   kernel/events/uprobes.c:1434:12: warning: 'dup_utask' defined but not used [-Wunused-function]
    static int dup_utask(struct task_struct *t, struct uprobe_task *o_utask)
               ^
   kernel/events/uprobes.c:1462:13: warning: 'uprobe_warn' defined but not used [-Wunused-function]
    static void uprobe_warn(struct task_struct *t, const char *msg)
                ^
   kernel/events/uprobes.c:1468:13: warning: 'dup_xol_work' defined but not used [-Wunused-function]
    static void dup_xol_work(struct callback_head *work)
                ^
   cc1: some warnings being treated as errors

vim +/if +2029 kernel/events/uprobes.c

0326f5a9 kernel/events/uprobes.c Srikar Dronamraju 2012-03-13  2023  
32cdba1e kernel/events/uprobes.c Oleg Nesterov     2012-11-14  2024  	if (percpu_init_rwsem(&dup_mmap_sem))
32cdba1e kernel/events/uprobes.c Oleg Nesterov     2012-11-14  2025  		return -ENOMEM;
32cdba1e kernel/events/uprobes.c Oleg Nesterov     2012-11-14  2026  
0326f5a9 kernel/events/uprobes.c Srikar Dronamraju 2012-03-13  2027  	return register_die_notifier(&uprobe_exception_nb);
2b144498 kernel/uprobes.c        Srikar Dronamraju 2012-02-09  2028  }
736e89d9 kernel/events/uprobes.c Oleg Nesterov     2013-10-31 @2029  __initcall(init_uprobes);

:::::: The code at line 2029 was first introduced by commit
:::::: 736e89d9f782a7dd9a38ecda13b2db916fa72f33 uprobes: Kill module_init() and module_exit()

:::::: TO: Oleg Nesterov <oleg@...hat.com>
:::::: CC: Oleg Nesterov <oleg@...hat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (21703 bytes)