linux-kernel - Re: [PATCH] uprobes: wait for mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Feb 2016 19:38:56 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Michal Hocko <mhocko@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH] uprobes: wait for mmap_sem for write killable

On 02/29, Michal Hocko wrote:
>
> On Mon 29-02-16 19:11:06, Oleg Nesterov wrote:
> > On 02/29, Michal Hocko wrote:
> > >
> > > --- a/kernel/events/uprobes.c
> > > +++ b/kernel/events/uprobes.c
> > > @@ -1130,7 +1130,9 @@ static int xol_add_vma(struct mm_struct *mm, struct xol_area *area)
> > >  	struct vm_area_struct *vma;
> > >  	int ret;
> > >
> > > -	down_write(&mm->mmap_sem);
> > > +	if (down_write_killable(&mm->mmap_sem))
> > > +		return -EINTR;
> > > +
> > >  	if (mm->uprobes_state.xol_area) {
> > >  		ret = -EALREADY;
> > >  		goto fail;
> > > @@ -1468,7 +1470,8 @@ static void dup_xol_work(struct callback_head *work)
> > >  	if (current->flags & PF_EXITING)
> > >  		return;
> > >
> > > -	if (!__create_xol_area(current->utask->dup_xol_addr))
> > > +	if (!__create_xol_area(current->utask->dup_xol_addr) &&
> > > +			!fatal_signal_pending(current)
> > >  		uprobe_warn(current, "dup xol area");
> > >  }
> >
> > Looks good, thanks.
>
> Can I consider this your Acked-by?

Yes, feel free to add. I forgot to add it.

Oleg.