linux-kernel - Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160229211223.GZ3965@htj.duckdns.org>
Date:	Mon, 29 Feb 2016 16:12:23 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Tirumalesh Chalamarla <tchalamarla@...iumnetworks.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, stripathi@....com,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536

Hello,

Sorry about the delay.

On Thu, Feb 25, 2016 at 12:31:53PM -0800, Tirumalesh Chalamarla wrote:
> On 02/17/2016 08:12 AM, Thomas Gleixner wrote:
> >On Tue, 16 Feb 2016, tchalamarla@...iumnetworks.com wrote:
> >>+#ifdef CONFIG_ARM64
> >>+/* Due to ERRATA#22536, ThunderX need to handle
> >>+ * HOST_IRQ_STAT differently.
> >>+ * Work around is to make sure all pending IRQs
> >>+ * are served before leaving handler
> >>+ */
> >>+static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance)
> >>+{
> >>+	struct ata_host *host = dev_instance;
> >>+	struct ahci_host_priv *hpriv;
> >>+	unsigned int rc = 0;
> >>+	void __iomem *mmio;
> >>+	u32 irq_stat, irq_masked;
> >>+	unsigned int handled = 1;
> >>+
> >>+	VPRINTK("ENTER\n");
> >
> >Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they
> >already track the enter/exit of interrupt handlers ....
> 
> sure. waiting for some more comments if any.

Yeah, VPRINTK way predates tracepoints and is kinda silly at this
point.  That said, it's used relatively consistently across libata and
some people still use it for debugging.  We can replace them with
proper tracepoints but that's a work for another patchset.  For now,
let's leave it in for consistency with counterparts.

Thanks.

-- 
tejun