linux-kernel - Re: [PATCH] [v2] x86, pkeys: fix siginfo ABI breakage from new field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160301091331.0ce9f1da@canb.auug.org.au>
Date:	Tue, 1 Mar 2016 09:13:31 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Dave Hansen <dave@...1.net>
Cc:	linux-kernel@...r.kernel.org, dave.hansen@...ux.intel.com,
	akpm@...ux-foundation.org, tglx@...utronix.de, mingo@...e.hu,
	hpa@...or.com, peterz@...radead.org, linux-next@...r.kernel.org,
	deller@....de
Subject: Re: [PATCH] [v2] x86, pkeys: fix siginfo ABI breakage from new
 field

Hi Dave,

On Mon, 29 Feb 2016 11:49:31 -0800 Dave Hansen <dave@...1.net> wrote:
>
> This responds to the feedback from Ingo that we should be using
> explicitly-sized types.

Beat me to it by seconds :-)

> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> Stephen Rothwell reported:
> 
> 	http://lkml.kernel.org/r/20160226164406.065a1ffc@canb.auug.org.au
> 
> that the Memory Protection Keys patches from the tip tree broke
> a build-time check on an ARM build because they changed the ABI
> of siginfo.
> 
> A u64 was used for the protection key field in siginfo.  When the
> containing union was aligned, this u64 unioned nicely with the
> two 'void *'s in _addr_bnd.  But, on 32-bit, if the union was
> unaligned, the u64 might grow the size of the union, breaking the
> ABI for subsequent fields.
> 
> To fix this, we replace the u64 with an 'unsigned long'.  The long
> is guaranteed to union well with the pointers from _addr_bnd.  It
> is also plenty large enough to store the 16-bit pkey we have today
> on x86.  This also has the advantage that it allows existing 64-bit
> userspace to keep working without modification.

s/(unsigned )?long/__u32/g
and the last sentence no longer makes sense.

> I also shouldn't have been using a u64 in a userspace API to begin
> with.
> 
> Fixes: cd0ea35ff551 ("signals, pkeys: Notify userspace about protection key faults")
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: linux-next@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Helge Deller <deller@....de>

Acked-by: Stehen Rothwell <sfr@...b.auug.org.au>

-- 
Cheers,
Stephen Rothwell