linux-kernel - Re: [PATCH] vfs: constify arguments to utime family of system calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Mar 2016 13:31:29 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Eric Biggers <ebiggers3@...il.com>
Cc:	kbuild-all@...org, linux-fsdevel@...r.kernel.org,
	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
	Eric Biggers <ebiggers3@...il.com>
Subject: Re: [PATCH] vfs: constify arguments to utime family of system calls

Hi Eric,

[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.5-rc6 next-20160229]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Eric-Biggers/vfs-constify-arguments-to-utime-family-of-system-calls/20160301-132301
config: alpha-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=alpha 

All warnings (new ones prefixed by >>):

   arch/alpha/kernel/osf_sys.c: In function 'SYSC_osf_utimes':
>> arch/alpha/kernel/osf_sys.c:1074:7: warning: passing argument 2 of 'get_tv32' discards 'const' qualifier from pointer target type
      if (get_tv32(&ktvs[0], &tvs[0]) ||
          ^
   arch/alpha/kernel/osf_sys.c:955:1: note: expected 'struct timeval32 *' but argument is of type 'const struct timeval32 *'
    get_tv32(struct timeval *o, struct timeval32 __user *i)
    ^
   arch/alpha/kernel/osf_sys.c:1075:7: warning: passing argument 2 of 'get_tv32' discards 'const' qualifier from pointer target type
          get_tv32(&ktvs[1], &tvs[1]))
          ^
   arch/alpha/kernel/osf_sys.c:955:1: note: expected 'struct timeval32 *' but argument is of type 'const struct timeval32 *'
    get_tv32(struct timeval *o, struct timeval32 __user *i)
    ^

vim +1074 arch/alpha/kernel/osf_sys.c

^1da177e Linus Torvalds 2005-04-16  1058  		return error;
^1da177e Linus Torvalds 2005-04-16  1059  
^1da177e Linus Torvalds 2005-04-16  1060  	if (put_it32(out, &kout))
^1da177e Linus Torvalds 2005-04-16  1061  		return -EFAULT;
^1da177e Linus Torvalds 2005-04-16  1062  
^1da177e Linus Torvalds 2005-04-16  1063  	return 0;
^1da177e Linus Torvalds 2005-04-16  1064  
^1da177e Linus Torvalds 2005-04-16  1065  }
^1da177e Linus Torvalds 2005-04-16  1066  
c7887325 David Howells  2010-08-11  1067  SYSCALL_DEFINE2(osf_utimes, const char __user *, filename,
ec284566 Eric Biggers   2016-02-29  1068  		const struct timeval32 __user *, tvs)
^1da177e Linus Torvalds 2005-04-16  1069  {
1c710c89 Ulrich Drepper 2007-05-08  1070  	struct timespec tv[2];
^1da177e Linus Torvalds 2005-04-16  1071  
^1da177e Linus Torvalds 2005-04-16  1072  	if (tvs) {
1c710c89 Ulrich Drepper 2007-05-08  1073  		struct timeval ktvs[2];
^1da177e Linus Torvalds 2005-04-16 @1074  		if (get_tv32(&ktvs[0], &tvs[0]) ||
^1da177e Linus Torvalds 2005-04-16  1075  		    get_tv32(&ktvs[1], &tvs[1]))
^1da177e Linus Torvalds 2005-04-16  1076  			return -EFAULT;
1c710c89 Ulrich Drepper 2007-05-08  1077  
1c710c89 Ulrich Drepper 2007-05-08  1078  		if (ktvs[0].tv_usec < 0 || ktvs[0].tv_usec >= 1000000 ||
1c710c89 Ulrich Drepper 2007-05-08  1079  		    ktvs[1].tv_usec < 0 || ktvs[1].tv_usec >= 1000000)
1c710c89 Ulrich Drepper 2007-05-08  1080  			return -EINVAL;
1c710c89 Ulrich Drepper 2007-05-08  1081  
1c710c89 Ulrich Drepper 2007-05-08  1082  		tv[0].tv_sec = ktvs[0].tv_sec;

:::::: The code at line 1074 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (45054 bytes)