linux-kernel - Re: [PATCH v2 13/13] ARM: sunxi: Introduce MACH_SUN8I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160301071253.GI8418@lukather>
Date:	Mon, 29 Feb 2016 23:12:53 -0800
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Vishnu Patekar <vishnupatekar0510@...il.com>
Cc:	robh+dt@...nel.org, corbet@....net, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, linux@....linux.org.uk, emilio@...pez.com.ar,
	jenskuske@...il.com, hdegoede@...hat.com, wens@...e.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
	linux-gpio@...r.kernel.org, linus.walleij@...aro.org,
	mturquette@...libre.com, sboyd@...eaurora.org,
	patchesrdh@...as.com, linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 13/13] ARM: sunxi: Introduce MACH_SUN8I_A83T option

Hi,

On Sun, Feb 28, 2016 at 11:18:58PM +0800, Vishnu Patekar wrote:
> A83T has CPUS clock similar to A80's. currently, a80 cpus clock only
> compiled for A80. So, Introduce MACH_SUN8I_A83T to compile it for
> A83T as well.
> 
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@...il.com>
> ---
>  arch/arm/mach-sunxi/Kconfig | 5 +++++
>  drivers/clk/sunxi/Makefile  | 3 +++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index c124d65..424b76d 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -41,6 +41,11 @@ config MACH_SUN8I
>  	select ARM_GIC
>  	select MFD_SUN6I_PRCM
>  
> +config MACH_SUN8I_A83T
> +	bool "Allwinner A83T (sun8i) SoCs support"
> +	default ARCH_SUNXI
> +	select ARM_GIC
> +
>  config MACH_SUN9I
>  	bool "Allwinner (sun9i) SoCs support"
>  	default ARCH_SUNXI
> diff --git a/drivers/clk/sunxi/Makefile b/drivers/clk/sunxi/Makefile
> index 3fd7901..2aabfc4 100644
> --- a/drivers/clk/sunxi/Makefile
> +++ b/drivers/clk/sunxi/Makefile
> @@ -20,6 +20,9 @@ obj-y += clk-usb.o
>  obj-$(CONFIG_MACH_SUN9I) += clk-sun8i-apb0.o
>  obj-$(CONFIG_MACH_SUN9I) += clk-sun9i-cpus.o
>  
> +obj-$(CONFIG_MACH_SUN8I_A83T) += clk-sun8i-apb0.o
> +obj-$(CONFIG_MACH_SUN8I_A83T) += clk-sun9i-cpus.o
> +

This is not how it should be done. You should rather create a Kconfig
option for these clocks, and use def_bool CONFIG_MACH_SUN8I || CONFIG_MACH_SUN9I

Switching to Kconfig for the clocks has been on my todo-list for quite
some time, I guess these two clocks would be a good start.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)