linux-kernel - Re: [PATCH v2 4/4] drivers: dma-coherent: use memset_io for DMA_MEMORY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Mar 2016 09:03:22 +0000
From:	Brian Starkey <brian.starkey@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Dan Williams <dan.j.williams@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] drivers: dma-coherent: use memset_io for
 DMA_MEMORY_IO mappings

Hi Andrew,

On Mon, Feb 29, 2016 at 03:17:49PM -0800, Andrew Morton wrote:
>On Mon, 29 Feb 2016 16:09:24 +0000 Brian Starkey <brian.starkey@....com> wrote:
>
>> Use memset_io() for DMA_MEMORY_IO mappings which are mapped as I/O
>> memory, and regular memset() for DMA_MEMORY_MAP mappings.
>>
>> This fixes the below alignment fault on arm64 for DMA_MEMORY_IO
>> mappings, where memset() uses the DC ZVA instruction which is
>> invalid on device memory.
>
>What's the urgency of this fix?  "Hair on fire needed in stable asap"
>or "Nice to have in there for 4.6" or what?
>

No-one else is complaining so probably not the former. If it could
make 4.6 though that would be grand.

As for stable, anything before 3.15 doesn't hit the fault (on arm64)
because memset() is different, so probably not needed there.
For anything after that this patch in isolation isn't a full fix,
because dma_init_coherent_memory() will still use the wrong mapping
function for DMA_MEMORY_MAP. In that case, I think it needs to be the
whole series or nothing. I don't have a strong opinion either way, but
perhaps someone else does.

Thanks
Brian