linux-kernel - Re: [PATCH v2 2/8] powerpc/module: Only try to generate the ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201603010955.ofALFSvz%fengguang.wu@intel.com>
Date:	Tue, 1 Mar 2016 09:40:50 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	kbuild-all@...org, linuxppc-dev@...abs.org, pmladek@...e.com,
	jeyu@...hat.com, jkosina@...e.cz, linux-kernel@...r.kernel.org,
	rostedt@...dmis.org, kamalesh@...ux.vnet.ibm.com, duwe@....de,
	live-patching@...r.kernel.org, mbenes@...e.cz
Subject: Re: [PATCH v2 2/8] powerpc/module: Only try to generate the
 ftrace_caller() stub once

Hi Michael,

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.5-rc6 next-20160229]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Michael-Ellerman/powerpc-Create-a-helper-for-getting-the-kernel-toc-value/20160229-172956
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-ppc6xx_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

Note: the linux-review/Michael-Ellerman/powerpc-Create-a-helper-for-getting-the-kernel-toc-value/20160229-172956 HEAD e702926c6f287a419f15b6b8451041fc7bd967f1 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/module_32.c: In function 'module_finalize_ftrace':
>> arch/powerpc/kernel/module_32.c:306:7: error: passing argument 3 of 'do_plt_call' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
          sechdrs, module);
          ^
   arch/powerpc/kernel/module_32.c:182:17: note: expected 'Elf32_Shdr * {aka struct elf32_shdr *}' but argument is of type 'const Elf32_Shdr * {aka const struct elf32_shdr *}'
    static uint32_t do_plt_call(void *location,
                    ^
>> arch/powerpc/kernel/module_32.c:307:7: error: 'mod' undeclared (first use in this function)
     if (!mod->arch.tramp)
          ^
   arch/powerpc/kernel/module_32.c:307:7: note: each undeclared identifier is reported only once for each function it appears in
   cc1: all warnings being treated as errors

vim +306 arch/powerpc/kernel/module_32.c

19558b67 arch/powerpc/kernel/module_32.c Michael Ellerman 2016-02-29  300  
7cc45e64 arch/powerpc/kernel/module_32.c Steven Rostedt   2008-11-15  301  #ifdef CONFIG_DYNAMIC_FTRACE
19558b67 arch/powerpc/kernel/module_32.c Michael Ellerman 2016-02-29  302  int module_finalize_ftrace(struct module *module, const Elf_Shdr *sechdrs)
19558b67 arch/powerpc/kernel/module_32.c Michael Ellerman 2016-02-29  303  {
19558b67 arch/powerpc/kernel/module_32.c Michael Ellerman 2016-02-29  304  	module->arch.tramp = do_plt_call(module->core_layout.base,
7cc45e64 arch/powerpc/kernel/module_32.c Steven Rostedt   2008-11-15  305  					 (unsigned long)ftrace_caller,
7cc45e64 arch/powerpc/kernel/module_32.c Steven Rostedt   2008-11-15 @306  					 sechdrs, module);
19558b67 arch/powerpc/kernel/module_32.c Michael Ellerman 2016-02-29 @307  	if (!mod->arch.tramp)
19558b67 arch/powerpc/kernel/module_32.c Michael Ellerman 2016-02-29  308  		return -ENOENT;
19558b67 arch/powerpc/kernel/module_32.c Michael Ellerman 2016-02-29  309  
^1da177e arch/ppc/kernel/module.c        Linus Torvalds   2005-04-16  310  	return 0;

:::::: The code at line 306 was first introduced by commit
:::::: 7cc45e64323c8a1042f56e6a8d1dc982f98d52a8 powerpc/ppc32: ftrace, dynamic ftrace to handle modules

:::::: TO: Steven Rostedt <srostedt@...hat.com>
:::::: CC: Steven Rostedt <srostedt@...hat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (27769 bytes)