linux-kernel - Re: [PATCH] qlogicpti: Return correct error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D58415.5090407@suse.de>
Date:	Tue, 1 Mar 2016 19:59:17 +0800
From:	Hannes Reinecke <hare@...e.de>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>, JBottomley@...n.com,
	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	julia.lawall@...6.fr
Subject: Re: [PATCH] qlogicpti: Return correct error code

On 02/17/2016 09:32 PM, Amitoj Kaur Chawla wrote:
> The return value of of_ioremap on failure should be -ENODEV and not
> -1.
> 
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
> 
> //<smpl>
> @@
> expression *e;
> @@
> 
> e = of_ioremap(...);
> if (e == NULL) {
> ...
> return
> - -1
> + -ENODEV
> ;
> }
> //</smpl>
> 
> The single call site only checks that the return value is less than 0,
> hence no change is required at the call site.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>  drivers/scsi/qlogicpti.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
> index 676385f..69bfc0a 100644
> --- a/drivers/scsi/qlogicpti.c
> +++ b/drivers/scsi/qlogicpti.c
> @@ -710,7 +710,7 @@ static int qpti_map_regs(struct qlogicpti *qpti)
>  				 "PTI Qlogic/ISP");
>  	if (!qpti->qregs) {
>  		printk("PTI: Qlogic/ISP registers are unmappable\n");
> -		return -1;
> +		return -ENODEV;
>  	}
>  	if (qpti->is_pti) {
>  		qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096),
> @@ -718,7 +718,7 @@ static int qpti_map_regs(struct qlogicpti *qpti)
>  					"PTI Qlogic/ISP statreg");
>  		if (!qpti->sreg) {
>  			printk("PTI: Qlogic/ISP status register is unmappable\n");
> -			return -1;
> +			return -ENODEV;
>  		}
>  	}
>  	return 0;
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)