linux-kernel - Re: [PATCH] tools build: use .s extension for preprocessed assembler code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Mar 2016 14:06:31 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-kernel@...r.kernel.org,
	Aaro Koskinen <aaro.koskinen@...ia.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Lukas Wunner <lukas@...ner.de>, Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] tools build: use .s extension for preprocessed assembler
 code

On Mon, Feb 01, 2016 at 02:59:00AM +0900, Masahiro Yamada wrote:
> The "man gcc" says .i extension represents the file is C source code
> that should not be preprocessed.  Here, .s should be used.
> 
> For clarification,
>   .c  ---(preprocess)--->  .i
>   .S  ---(preprocess)--->  .s

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  tools/build/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 4a96473..ee566e8 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
>  	$(call rule_mkdir)
>  	$(call if_changed_dep,cc_i_c)
>  
> -$(OUTPUT)%.i: %.S FORCE
> +$(OUTPUT)%.s: %.S FORCE
>  	$(call rule_mkdir)
>  	$(call if_changed_dep,cc_i_c)
>  
> -- 
> 1.9.1
>