linux-kernel - Re: [RFC PATCH v1 2/2] powerpc/86xx: Introduce and use common dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPk1OjG8hFAtJM1wLFcTHCD1Ld9fKuvcZgKpuDZ1=o-_RQGXOw@mail.gmail.com>
Date:	Tue, 1 Mar 2016 15:55:31 +0100
From:	Alessio Igor Bogani <alessio.bogani@...ttra.eu>
To:	Scott Wood <oss@...error.net>
Cc:	Kumar Gala <galak@...nel.crashing.org>,
	linuxppc-dev@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v1 2/2] powerpc/86xx: Introduce and use common dtsi

Scott,

On 29 February 2016 at 23:38, Scott Wood <oss@...error.net> wrote:
[...]
> Could you post a diff of what the decompiled trees look like before and after
> this change (e.g. interrupts went from 2-cell to 4-cell)?  It is very hard to
> review in this form.  Or better, like the config change, have a commit that
> first makes changes to what the unified trees will be, and then a second
> commit that generates the same output using includes.

Yes I'll surely do it.

>> +/include/ "qoriq-mpic.dtsi"
>> +     pic@...00 {
>> +             compatible = "chrp,open-pic";
>> +     };
>
> This is removing the fsl,mpic compatible, which is required for 4-cell
> interrupt specifiers.

Ok.

>> +&pci0 {
>> +     compatible = "fsl,mpc8641-pcie";
>> +     device_type = "pci";
>> +     #size-cells = <2>;
>> +     #address-cells = <3>;
>> +     bus-range = <0x0 0xff>;
>> +     clock-frequency = <33333333>;
>
> The clock frequency of PCI Express is not 33 MHz.

A lot of dtsi files into fsl directory have got that value!

>> diff --git a/arch/powerpc/boot/dts/fsl/mpc8641si-pre.dtsi
[...]
>> +/dts-v1/;
>> +
>> +/ {
>> +     compatible = "fsl,MPC8641";
>
> This compatible is pointless -- it will be overwritten by the board
> compatible.

Ok.

Thanks for have reviewed my patches.

Ciao,
Alessio