linux-kernel - Re: [PATCH] rtc: rtc-vr41xx: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Mar 2016 16:20:34 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [PATCH] rtc: rtc-vr41xx: remove unused function

On 01/03/2016 at 15:55:58 +0100, Thierry Reding wrote :
> On Tue, Mar 01, 2016 at 06:26:21PM +0530, Sudip Mukherjee wrote:
> > We were getting build warning about:
> > drivers/rtc/rtc-vr41xx.c:228:12: warning: ‘vr41xx_rtc_alarm_irq_enable’
> > defined but not used
> > 
> > The function vr41xx_rtc_alarm_irq_enable() was not used anywhere.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> > ---
> > 
> > build log is at:
> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/112780206
> > 
> >  drivers/rtc/rtc-vr41xx.c | 18 ------------------
> >  1 file changed, 18 deletions(-)
> > 
> > diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c
> > index f64c282..68cb63e 100644
> > --- a/drivers/rtc/rtc-vr41xx.c
> > +++ b/drivers/rtc/rtc-vr41xx.c
> > @@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long
> >  	return 0;
> >  }
> >  
> > -static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
> > -{
> > -	spin_lock_irq(&rtc_lock);
> > -	if (enabled) {
> > -		if (!alarm_enabled) {
> > -			enable_irq(aie_irq);
> > -			alarm_enabled = 1;
> > -		}
> > -	} else {
> > -		if (alarm_enabled) {
> > -			disable_irq(aie_irq);
> > -			alarm_enabled = 0;
> > -		}
> > -	}
> > -	spin_unlock_irq(&rtc_lock);
> > -	return 0;
> > -}
> > -
> 
> I don't think it's supposed to be unused, rather back at the time it
> simply wasn't hooked up to the rtc_class_ops.
> 
> Here's what I used.
> 

I've already applied the patch from Geert which does the same.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com