linux-kernel - Re: [PATCH v2] tty: audit: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56D5BEEA.7010206@hurleysoftware.com>
Date:	Tue, 1 Mar 2016 08:10:18 -0800
From:	Peter Hurley <peter@...leysoftware.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tty: audit: remove unused variable

On 02/24/2016 03:15 AM, Sudip Mukherjee wrote:
> While building with W=1 we were getting build warning:
> drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used
> 
> The local variable sessionid was only assigned the value of
> current->sessionid but was never reused. On further inspection it turned
> out that there is no need of audit_get_loginuid() also.

Reviewed-by: Peter Hurley <peter@...leysoftware.com>