linux-kernel - Re: [PATCH] i2c-thunderx: fix compile error for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56D5CB1D.7010104@caviumnetworks.com>
Date:	Tue, 1 Mar 2016 09:02:21 -0800
From:	David Daney <ddaney@...iumnetworks.com>
To:	Jan Glauber <jglauber@...ium.com>
CC:	Wolfram Sang <wsa@...-dreams.de>, <linux-kernel@...r.kernel.org>,
	<linux-i2c@...r.kernel.org>
Subject: Re: [PATCH] i2c-thunderx: fix compile error for x86_64

On 03/01/2016 05:53 AM, Jan Glauber wrote:
> The i2c-thunderx driver only depends on 64BIT and PCI,
> because there is no reason to limit it to ARM64.
>
> Adjusting the check in the header file that selects Octeon
> or ThunderX values to check for CONFIG_I2C_THUNDERX
> instead of CONFIG_ARCH_THUNDER fixes the compile error
> on x86_64.
>
> Signed-off-by: Jan Glauber <jglauber@...ium.com>

Yes, CONFIG_ARCH_THUNDER must die wherever it is encountered.

Acked-by: David Daney <david.daney@...ium.com>

That said, since the previous patch set didn't build under some 
configurations, can you fold this in, and submit a v2 that is complete 
and stand alone?

Thanks,
David Daney

> ---
>   drivers/i2c/busses/i2c-cavium.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cavium.h b/drivers/i2c/busses/i2c-cavium.h
> index 8357997..c7398f4 100644
> --- a/drivers/i2c/busses/i2c-cavium.h
> +++ b/drivers/i2c/busses/i2c-cavium.h
> @@ -8,7 +8,7 @@
>   #include <linux/pci.h>
>
>   /* Register offsets */
> -#ifdef CONFIG_ARCH_THUNDER
> +#ifdef CONFIG_I2C_THUNDERX
>   	#define SW_TWSI			0x1000
>   	#define TWSI_INT		0x1010
>   	#define SW_TWSI_EXT		0x1018
>