linux-kernel - Re: [PATCH RT 07/12] dump stack: dont disable preemption during trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160301132546.4aef9949@gandalf.local.home>
Date:	Tue, 1 Mar 2016 13:25:46 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Cc:	linux-kernel@...r.kernel.org,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Carsten Emde <C.Emde@...dl.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	John Kacur <jkacur@...hat.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH RT 07/12] dump stack: dont disable preemption during
 trace

On Tue, 1 Mar 2016 09:45:05 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Sat, 27 Feb 2016 11:32:06 +0100
> Sebastian Andrzej Siewior <sebastian@...akpoint.cc> wrote:
> 
> > On 2016-02-26 16:32:42 [-0500], Steven Rostedt wrote:  
> > > 3.18.27-rt26-rc1 stable review patch.
> > > If anyone has any objections, please let me know.    
> > 
> > Please merge this one along with "kernel: migrate_disable() do fastpath
> > in atomic & irqs-off". Otherwise we might get recursive with lockdep and
> > CPU-hotplug (if we go after hp->lock in pin_current_cpu()).  
> 
> Interesting. When I pulled this patch into 4.1-rt, it caused the system
> to lock up. I'm looking into it now.

And that's because this commit also needs:

"kernel: softirq: unlock with irqs on"

And due to the WARN_ON_ONCE() issue (that I just posted a patch to fix
mainline), it caused my system to reboot.

http://lkml.kernel.org/r/20160301110939.1b786f49@gandalf.local.home

-- Steve