linux-kernel - Re: [RFCv7 PATCH 03/10] sched: scheduler-driven cpu frequency selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ioxysoFjVxdPKZ7OYW0Xoz3kiqCYM3ywfWSqiMGCLscw@mail.gmail.com>
Date:	Tue, 1 Mar 2016 20:44:59 +0100
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Steve Muckle <steve.muckle@...aro.org>,
	Ingo Molnar <mingo@...hat.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Morten Rasmussen <morten.rasmussen@....com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Juri Lelli <Juri.Lelli@....com>,
	Patrick Bellasi <patrick.bellasi@....com>,
	Michael Turquette <mturquette@...libre.com>,
	Ricky Liang <jcliang@...omium.org>
Subject: Re: [RFCv7 PATCH 03/10] sched: scheduler-driven cpu frequency selection

On Tue, Mar 1, 2016 at 1:57 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Sat, Feb 27, 2016 at 01:08:02AM +0100, Rafael J. Wysocki wrote:
>> @@ -95,18 +98,20 @@ EXPORT_SYMBOL_GPL(cpufreq_set_update_uti
>>   *
>>   * This function is called by the scheduler on every invocation of
>>   * update_load_avg() on the CPU whose utilization is being updated.
>> + *
>> + * It can only be called from RCU-sched read-side critical sections.
>>   */
>>  void cpufreq_update_util(u64 time, unsigned long util, unsigned long max)
>>  {
>>       struct update_util_data *data;
>>
>> -     rcu_read_lock();
>> -
>
> Maybe, just because I'm paranoid, add something like:
>
> #ifdef CONFIG_LOCKDEP
>         WARN_ON(debug_locks && !rcu_read_lock_sched_held());
> #endif

OK