lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Mar 2016 12:02:01 -0800 From: Hongzhou Yang <hongzhou.yang@...iatek.com> To: Paul Gortmaker <paul.gortmaker@...driver.com> CC: <linux-kernel@...r.kernel.org>, Linus Walleij <linus.walleij@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, <linux-gpio@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <yingjoe.chen@...iatek.com>, <eddie.huang@...iatek.com>, <biao.huang@...iatek.com> Subject: Re: [PATCH 2/8] drivers/pinctrl: make mediatek/pinctrl-mt6397 driver explicitly non-modular On Mon, 2016-02-29 at 15:48 -0500, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config PINCTRL_MT6397 > bool "Mediatek MT6397 pin control" if COMPILE_TEST && !MFD_MT6397 > > ...meaning that it is currently not being built as a module by anyone. > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Linus Walleij <linus.walleij@...aro.org> > Cc: Matthias Brugger <matthias.bgg@...il.com> > Cc: Hongzhou Yang <hongzhou.yang@...iatek.com> > Cc: linux-gpio@...r.kernel.org > Cc: linux-mediatek@...ts.infradead.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> > --- > drivers/pinctrl/mediatek/pinctrl-mt6397.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt6397.c b/drivers/pinctrl/mediatek/pinctrl-mt6397.c > index f9751ae28e32..6eccb85c02cd 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mt6397.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mt6397.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > */ > > -#include <linux/module.h> > +#include <linux/init.h> > #include <linux/platform_device.h> > #include <linux/of.h> > #include <linux/of_device.h> > @@ -55,7 +55,6 @@ static const struct of_device_id mt6397_pctrl_match[] = { > { .compatible = "mediatek,mt6397-pinctrl", }, > { } > }; > -MODULE_DEVICE_TABLE(of, mt6397_pctrl_match); > > static struct platform_driver mtk_pinctrl_driver = { > .probe = mt6397_pinctrl_probe, > @@ -69,9 +68,4 @@ static int __init mtk_pinctrl_init(void) > { > return platform_driver_register(&mtk_pinctrl_driver); > } > - > -module_init(mtk_pinctrl_init); > - > -MODULE_LICENSE("GPL v2"); > -MODULE_DESCRIPTION("MediaTek MT6397 Pinctrl Driver"); > -MODULE_AUTHOR("Hongzhou Yang <hongzhou.yang@...iatek.com>"); > +device_initcall(mtk_pinctrl_init); Acked-by: Hongzhou Yang <hongzhou.yang@...iatek.com> Thanks, Hongzhou
Powered by blists - more mailing lists