linux-kernel - Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZBZyGwhheHz_Smo_5kv36fpenM9HD+ab-u1qsfko0mvQQ@mail.gmail.com>
Date:	Tue, 1 Mar 2016 22:38:35 +0200
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Daniel Baluta <daniel.baluta@...el.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-i2c@...r.kernel.org,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Ge Gao <ggao@...ensense.com>,
	Adriana Reus <adi.reus@...il.com>, Crt Mori <cmo@...exis.com>,
	Michael Welling <mwelling@...e.org>
Subject: Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback

On Tue, Mar 1, 2016 at 10:30 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
> On Thu, Feb 18, 2016 at 05:53:13PM +0200, Daniel Baluta wrote:
>> From: Adriana Reus <adriana.reus@...el.com>
>>
>> Add a check in i2c_mux_master_xfer before calling the select callback.
>> This is necessary so that NULL callbacks can be safely registered.
>>
>> Signed-off-by: Adriana Reus <adriana.reus@...el.com>
>> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>
>
> Hmm, rather than supporting that in the core, I'd prefer to have the
> driver pass an empty function instead. Then, in the driver, we can have
> a comment explaining the special situation.

Agree. This seems a better idea forcing the user to explain the situation :).