linux-kernel - Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12391836.3mgJ3uDMLr@wuerfel>
Date:	Tue, 01 Mar 2016 22:30:26 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Alexandre Courbot <acourbot@...dia.com>
Cc:	Ulf Hansson <ulf.hansson@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-mmc@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, gnurou@...il.com
Subject: Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask

On Tuesday 01 March 2016 13:32:43 Alexandre Courbot wrote:
>          */
> -       if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA))) {
> +       if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA)))
>                 host->dma_mask = DMA_BIT_MASK(64);
> -               mmc_dev(mmc)->dma_mask = &host->dma_mask;
> -       }
> +
> +       if (host->dma_mask &&
> +           dma_set_mask_and_coherent(mmc_dev(mmc), host->dma_mask))
> +               pr_warn("%s: cannot set DMA mask\n", mmc_hostname(mmc));
> 

Looks good, 

Acked-by: Arnd Bergmann <arnd@...db.de>