linux-kernel - Re: [PATCH mmotm] mm, sl[au]b: print gfp_flags as strings in slab_out_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1603011439390.24913@chino.kir.corp.google.com>
Date:	Tue, 1 Mar 2016 14:41:39 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Vlastimil Babka <vbabka@...e.cz>
cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Christoph Lameter <cl@...ux.com>,
	Pekka Enberg <penberg@...nel.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH mmotm] mm, sl[au]b: print gfp_flags as strings in
 slab_out_of_memory()

On Tue, 1 Mar 2016, Vlastimil Babka wrote:

> We can now print gfp_flags more human-readable. Make use of this in
> slab_out_of_memory() for SLUB and SLAB. Also convert the SLAB variant it to
> pr_warn() along the way.
> 
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: Pekka Enberg <penberg@...nel.org>
> Cc: David Rientjes <rientjes@...gle.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@....com>

Acked-by: David Rientjes <rientjes@...gle.com>

Although I've always been curious about the usefulness of these out of 
memory calls in the first place.  They are obviously for debugging, but 
have they actually helped to diagnose anything?