linux-kernel - Re: [PATCH 5/7] perf, tools, stat: Implement --metric-only mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160302153506.GX5083@two.firstfloor.org>
Date:	Wed, 2 Mar 2016 16:35:07 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
	jolsa@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 5/7] perf, tools, stat: Implement --metric-only mode

> > @@ -1229,6 +1397,8 @@ static void print_counters(struct timespec *ts, int argc, const char **argv)
> >  	case AGGR_GLOBAL:
> >  		evlist__for_each(evsel_list, counter)
> >  			print_counter_aggr(counter, prefix);
> > +		if (metric_only)
> > +			fputc('\n', stat_config.output);
> 
> this new line printing based on metric_only is all over the place..
> could we sorted out new lines in the print callbacks?  this makes
> my head hurt ;-)

I don't see how a print callback could handle it. It has no idea
where the event list ends. Only the high level display function
knows that, and it prints the newlines.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.