linux-kernel - [PATCH 00/14] drivers: use __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Wed,  2 Mar 2016 16:58:52 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	unlisted-recipients:; (no To-header on input)
Cc:	linux-arm-kernel@...ts.infradead.org,
	Arnd Bergmann <arnd@...db.de>, herbert@...dor.apana.org.au,
	k.kozlowski@...sung.com, dan.j.williams@...el.com,
	vinod.koul@...el.com, baohua@...nel.org, dmitry.torokhov@...il.com,
	tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com,
	laurent.pinchart@...asonboard.com, mchehab@....samsung.com,
	lee.jones@...aro.org, kvalo@...eaurora.org,
	ludovic.desroches@...el.com, linus.walleij@...aro.org,
	sre@...nel.org, dbaryshkov@...il.com, JBottomley@...n.com,
	martin.petersen@...cle.com, broonie@...nel.org,
	linux-crypto@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-input@...r.kernel.org, linux-media@...r.kernel.org,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-scsi@...r.kernel.org, alsa-devel@...a-project.org,
	linux-rockchip@...ts.infradead.org
Subject: [PATCH 00/14] drivers: use __maybe_unused to hide pm functions

I found many variations of the bug in these device drivers (and some
USB drivers I already send patches for in a separate series).

In each case, the power management operations structure conditionally
references suspend/resume functions, but the functions are hidden
in an incorrect #ifdef or not hidden at all.

We could try to correct the #ifdefs, but it seems easier to just
mark those functions as __maybe_unused, which has the same effect
but provides better compile-time test coverage and (subjectively)
looks a bit nicer.

I have a patch series that avoids all warnings in ARM randconfig
builds, and I have verified that all these patches fix a warning that
is still present in today's linux-next, and that they do not
introduce new warnings in any configuration I found.

Note that all these drivers are ARM specific, so I assume that
all portable drivers got fixed already when someone rand into
the problem on x86.

There are no dependencies between the patches, so I'd appreciate
subsystem maintainers to put them directly into their git trees.

	Arnd

Arnd Bergmann (14):
  pinctrl: at91: use __maybe_unused to hide pm functions
  irqchip: st: use __maybe_unused to hide st_irq_syscfg_resume
  power: ipaq-micro-battery: use __maybe_unused to hide pm functions
  power: pm2301-charger: use __maybe_unused to hide pm functions
  mfd: ipaq-micro: use __maybe_unused to hide pm functions
  dma: sirf: use __maybe_unused to hide pm functions
  hw_random: exynos: use __maybe_unused to hide pm functions
  scsi: mvumi: use __maybe_unused to hide pm functions
  amd-xgbe: use __maybe_unused to hide pm functions
  wireless: cw1200: use __maybe_unused to hide pm functions_
  input: spear-keyboard: use __maybe_unused to hide pm functions
  keyboard: snvs-pwrkey: use __maybe_unused to hide pm functions
  [media] omap3isp: use IS_ENABLED() to hide pm functions
  ASoC: rockchip: use __maybe_unused to hide st_irq_syscfg_resume

 drivers/char/hw_random/exynos-rng.c         | 10 ++++------
 drivers/dma/sirf-dma.c                      | 10 ++++------
 drivers/input/keyboard/snvs_pwrkey.c        |  4 ++--
 drivers/input/keyboard/spear-keyboard.c     |  6 ++----
 drivers/irqchip/irq-st.c                    |  2 +-
 drivers/media/platform/omap3isp/isp.c       | 13 +------------
 drivers/mfd/ipaq-micro.c                    |  2 +-
 drivers/net/ethernet/amd/xgbe/xgbe-main.c   |  6 ++----
 drivers/net/wireless/st/cw1200/cw1200_spi.c |  9 ++-------
 drivers/net/wireless/st/cw1200/pm.h         |  9 +++++++--
 drivers/pinctrl/pinctrl-at91-pio4.c         |  4 ++--
 drivers/power/ipaq_micro_battery.c          |  4 ++--
 drivers/power/pm2301_charger.c              | 22 ++++++----------------
 drivers/scsi/mvumi.c                        |  4 ++--
 sound/soc/rockchip/rockchip_spdif.c         |  4 ++--
 15 files changed, 40 insertions(+), 69 deletions(-)

-- 
2.7.0
Cc: herbert@...dor.apana.org.au
Cc: k.kozlowski@...sung.com
Cc: dan.j.williams@...el.com
Cc: vinod.koul@...el.com
Cc: baohua@...nel.org
Cc: dmitry.torokhov@...il.com
Cc: tglx@...utronix.de
Cc: jason@...edaemon.net
Cc: marc.zyngier@....com
Cc: laurent.pinchart@...asonboard.com
Cc: mchehab@....samsung.com
Cc: lee.jones@...aro.org
Cc: kvalo@...eaurora.org
Cc: ludovic.desroches@...el.com
Cc: linus.walleij@...aro.org
Cc: sre@...nel.org
Cc: dbaryshkov@...il.com
Cc: JBottomley@...n.com
Cc: martin.petersen@...cle.com
Cc: broonie@...nel.org
Cc: linux-crypto@...r.kernel.org
Cc: linux-arm-kernel@...ts.infradead.org
Cc: linux-samsung-soc@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Cc: dmaengine@...r.kernel.org
Cc: linux-input@...r.kernel.org
Cc: linux-media@...r.kernel.org
Cc: netdev@...r.kernel.org
Cc: linux-wireless@...r.kernel.org
Cc: linux-gpio@...r.kernel.org
Cc: linux-pm@...r.kernel.org
Cc: linux-scsi@...r.kernel.org
Cc: alsa-devel@...a-project.org
Cc: linux-rockchip@...ts.infradead.org