linux-kernel - RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN3PR0101MB105786CD2D33475567651B20D0BC0@BN3PR0101MB1057.prod.exchangelabs.com>
Date:	Wed, 2 Mar 2016 16:21:57 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro

On Wednesday, March 02, 2016 7:28 AM, Ian Abbott wrote:
> Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging:
> comedi: Prefer using the BIT macro"), but I replaced the use of the BIT
> macro with hexadecimal constants instead of the original left bit-shift
> expressions.  We shouldn't use the BIT macro in "comedi.h" as it is
> intended to be included in the UAPI headers.
>
> Patch 2 just fixes the kernel-doc comment for struct comedi_krange.
>
> 1) staging: comedi: comedi.h: Do not use BIT macro
> 2) staging: comedi: comedi.h: Fix comment for struct comedi_krange
>
>  drivers/staging/comedi/comedi.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Thanks for fixing this. I noticed the same issue yesterday.

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>