linux-kernel - Re: [PATCH] ARM: at91: avoid defining CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2506540.Af9r4eEVXL@wuerfel>
Date:	Wed, 02 Mar 2016 17:31:44 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Olof Johansson <olof@...om.net>,
	ARM Maintainers <arm@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: at91: avoid defining CONFIG_* symbols in source code

On Wednesday 02 March 2016 16:46:35 Nicolas Ferre wrote:
> Le 23/02/2016 15:39, Arnd Bergmann a écrit :
> > In an invalid randconfig build (fixed by another patch),
> > I ran across this warning:
> > 
> > arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror]
> >  #define CONFIG_DEBUG_UART_VIRT AT91_IO_P2V(CONFIG_DEBUG_UART_PHYS)
> > 
> > As Russell pointed out, we should never #define a macro starting
> > with CONFIG_ in a source file, as that is rather confusing.
> > 
> > This renames the macro to avoid the symbol clash.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Suggested-by: Russell King <linux@....linux.org.uk>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
> 
> Arnd,
> 
> Can you please add this patch on top of the arm-soc branches "soc" or
> "cleanup" for 4.6.
> I don't think that we will have more material for these branches to send
> to you before the opening of the merge window.
> 
> Thanks for your patch, bye.

Applied to next/soc, thanks!

	Arnd