[<prev] [next>] [day] [month] [year] [list]
Message-ID: <56D71BFF.2020104@osg.samsung.com>
Date: Wed, 2 Mar 2016 09:59:43 -0700
From: Shuah Khan <shuahkh@....samsung.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: mchehab@....samsung.com, tiwai@...e.com, clemens@...isch.de,
hans.verkuil@...co.com, sakari.ailus@...ux.intel.com,
javier@....samsung.com, pawel@...iak.com, m.szyprowski@...sung.com,
kyungmin.park@...sung.com, perex@...ex.cz, arnd@...db.de,
dan.carpenter@...cle.com, tvboxspy@...il.com, crope@....fi,
ruchandani.tina@...il.com, corbet@....net, chehabrafael@...il.com,
k.kozlowski@...sung.com, stefanr@...6.in-berlin.de,
inki.dae@...sung.com, jh1009.sung@...sung.com,
elfring@...rs.sourceforge.net, prabhakar.csengg@...il.com,
sw0312.kim@...sung.com, p.zabel@...gutronix.de,
ricardo.ribalda@...il.com, labbott@...oraproject.org,
pierre-louis.bossart@...ux.intel.com, ricard.wanderlof@...s.com,
julian@...st.de, takamichiho@...il.com, dominic.sacre@....de,
misterpib@...il.com, daniel@...que.org, gtmkramer@...all.nl,
normalperson@...t.net, joe@...po.co.uk, linuxbugs@...tgam.net,
johan@...ud.se, klock.android@...il.com, nenggun.kim@...sung.com,
j.anaszewski@...sung.com, geliangtang@....com,
"al bert"@huitsing.nl, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, alsa-devel@...a-project.org,
Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v4 22/22] sound/usb: Use Media Controller API to share
media resources
On 03/01/2016 12:53 PM, Laurent Pinchart wrote:
> Hi Shuah,
>
> Thank you for the patch.
>
snip
>> +struct media_mixer_ctl {
>> + struct media_device *media_dev;
>> + struct media_entity media_entity;
>> + struct media_intf_devnode *intf_devnode;
>> + struct media_link *intf_link;
>> + struct media_pad media_pad[MEDIA_MIXER_PAD_MAX];
>> + struct media_pipeline media_pipe;
>> +};
>> +
>> +int media_device_create(struct snd_usb_audio *chip,
>> + struct usb_interface *iface);
>> +void media_device_delete(struct snd_usb_audio *chip);
>> +int media_stream_init(struct snd_usb_substream *subs, struct snd_pcm *pcm,
>> + int stream);
>> +void media_stream_delete(struct snd_usb_substream *subs);
>> +int media_start_pipeline(struct snd_usb_substream *subs);
>> +void media_stop_pipeline(struct snd_usb_substream *subs);
>
> As this API is sound-specific, would it make sense to call the functions
> media_snd_* or something similar ? The names are very generic now, and could
> clash with core media code.
Thanks. I renamed the interfaces. Please see patch v5
that was sent out a little while ago.
-- Shuah
>
>> +#else
>> +static inline int media_device_create(struct snd_usb_audio *chip,
>> + struct usb_interface *iface)
>> + { return 0; }
>> +static inline void media_device_delete(struct snd_usb_audio *chip) { }
>> +static inline int media_stream_init(struct snd_usb_substream *subs,
>> + struct snd_pcm *pcm, int stream)
>> + { return 0; }
>> +static inline void media_stream_delete(struct snd_usb_substream *subs) { }
>> +static inline int media_start_pipeline(struct snd_usb_substream *subs)
>> + { return 0; }
>> +static inline void media_stop_pipeline(struct snd_usb_substream *subs) { }
>> +#endif
>> +#endif /* __MEDIA_H */
>
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
Powered by blists - more mailing lists