linux-kernel - Re: [RESEND RFC 1/3] nvmem: Add 'of_nvmem_cell_from_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqGE-59=jgGsfpj4x8fYQZpAka_DwnK5jb5REG5MJ2dP0Q@mail.gmail.com>
Date:	Wed, 2 Mar 2016 10:11:36 -0800
From:	Andrey Smirnov <andrew.smirnov@...il.com>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	linux-kernel@...r.kernel.org, maxime.ripard@...e-electrons.com
Subject: Re: [RESEND RFC 1/3] nvmem: Add 'of_nvmem_cell_from_device_node()'

On Wed, Mar 2, 2016 at 5:58 AM, Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
> Sorry for so late review comments,
>
>
> On 01/03/16 16:59, Andrey Smirnov wrote:
>>
>> Add 'of_nvmem_cell_from_device_node()' -- a function that allows to
>> obtain 'struct nvmem_cell' from a device tree node representing it. One
>> use-case for such a function would be to access nvmem cells with known
>> phandles.
>
>
> Totally missing the purpose of this new API, Why is of_nvmem_cell_get() not
> useful, its exactly doing same thing.
>
> Unless you randomly want to handle phandles without proper dt bindings.

That about sums up what I was trying to do. In my "composite" driver,
the way the layout of the cell is specified is a 3-element tuple
containing a phandle to nvmem cell, offset within that cell and the
size of the chunk to use, so in order to be able to use that phandle I
introduced this function.

Andrey