linux-kernel - Re: [PATCH] batman-adv: clarify CFG80211 dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160302.134603.447218907358875583.davem@davemloft.net>
Date:	Wed, 02 Mar 2016 13:46:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	a@...table.cc
Cc:	arnd@...db.de, linux-arm-kernel@...ts.infradead.org,
	mareklindner@...mailbox.ch, sw@...onwunderlich.de,
	b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] batman-adv: clarify CFG80211 dependency

From: Antonio Quartulli <a@...table.cc>
Date: Wed, 2 Mar 2016 22:46:07 +0800

> On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
>> The driver calls cfg80211_get_station, which may be part of a
>> module, so we must not enable BATMAN_ADV_BATMAN_V if
>> BATMAN_ADV=y and CFG80211=m:
>> 
>> net/built-in.o: In function `batadv_v_elp_get_throughput':
>> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>> 
>> This clarifies the dependency to cover all combinations.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
> 
> Acked-by: Antonio Quartulli <a@...table.cc>
> 
> Thanks a lot Arnd!
> 
> David, could you please merge this change in net-next directly ?

Done, applied, thanks everyone.