linux-kernel - RE: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575E9C847DA64B429BF50A3C5F8CA3CCA3C3C087@ORSMSX112.amr.corp.intel.com>
Date:	Wed, 2 Mar 2016 19:15:14 +0000
From:	"Pottratz, Dwane" <dwane.pottratz@...el.com>
To:	Joe Perches <joe@...ches.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andy Whitcroft <apw@...onical.com>
Subject: RE: [PATCH] checkpatch.pl: add switch to turn off check for
 Change-Id

Hi Joe,

Locally I will remove the patch and use the '--ignore' option.  

Is there anything I need to do for upstream?  (Sorry, I am new to submitting patches upstream)

-Dwane

-----Original Message-----
From: Joe Perches [mailto:joe@...ches.com] 
Sent: Tuesday, March 1, 2016 3:22 PM
To: Pottratz, Dwane <dwane.pottratz@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>; LKML <linux-kernel@...r.kernel.org>; Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id

On Tue, 2016-03-01 at 21:49 +0000, Pottratz, Dwane wrote:
> Good to know.  Thx.

Andrew picked this up, but it might be better to remove your patch and just use the --ignore option as --ignore is generic and your patch just duplicates the capability.


> 
> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Tuesday, March 1, 2016 1:41 PM
> To: Pottratz, Dwane <dwane.pottratz@...el.com>; apw@...onical.com; li 
> nux-kernel@...r.kernel.org; 'akpm@...ux-foundation.org' <akpm@...ux-f 
> oundation.org>
> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for 
> Change-Id
> 
> On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote:
> > 
> > A commit hook for the Gerrit code review servers inserts change 
> > identifiers.  These identifiers are noise in the context of the 
> > upstream kernel.  However, they are needed in most development 
> > environments and the error needs to be ignored for static analysis 
> > tools.
> btw: another way to do this is to use the --ignore <foo-list> option.
> 
> $ ./scripts/checkpatch.pl --ignore gerrit_change_id <patch>
>