linux-kernel - Re: [patch] rtc: ds1685: passing bogus values to irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160302233609.GC2567@piout.net>
Date:	Thu, 3 Mar 2016 00:36:09 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Joshua Kinard <kumba@...too.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] rtc: ds1685: passing bogus values to irq_restore

On 02/03/2016 at 13:07:45 +0300, Dan Carpenter wrote :
> We call spin_lock_irqrestore with "flags" set to zero instead of to the
> value from spin_lock_irqsave().
> 
> Fixes: aaaf5fbf56f1 ('rtc: add driver for DS1685 family of real time clocks')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com