lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Mar 2016 15:55:33 -0800 From: Tony Lindgren <tony@...mide.com> To: Stephen Boyd <sboyd@...eaurora.org> Cc: Michael Turquette <mturquette@...libre.com>, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, Tero Kristo <t-kristo@...com> Subject: Re: [PATCH] clk: ti: Fix some errors found by static checkers * Stephen Boyd <sboyd@...eaurora.org> [160301 10:55]: > drivers/clk/ti/clk-814x.c:34:12: warning: symbol 'dm814x_adpll_early_init' was not declared. Should it be static? > drivers/clk/ti/clk-814x.c:58:12: warning: symbol 'dm814x_adpll_enable_init_clocks' was not declared. Should it be static? > drivers/clk/ti/adpll.c:465 ti_adpll_recalc_rate() warn: should '__readw(d->regs + 20) << 18' be a 64 bit type? > drivers/clk/ti/adpll.c:945 ti_adpll_probe() error: we previously assumed 'd->clocks' could be null (see line 921) > > The last one looks like a real bug because we don't return an > error on allocation failure. Yeah nice, that's a real bug: Tested-by: Tony Lindgren <tony@...mide.com>
Powered by blists - more mailing lists