linux-kernel - Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D64A25.5050700@nvidia.com>
Date:	Wed, 2 Mar 2016 07:34:21 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	<alexandre.belloni@...e-electrons.com>, <a.zummo@...ertech.it>
CC:	<cw00.choi@...sung.com>, <rtc-linux@...glegroups.com>,
	<linux-kernel@...r.kernel.org>, <javier@....samsung.com>,
	<rklein@...dia.com>
Subject: Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs
 initialisation


On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote:
> On 29.02.2016 21:58, Laxman Dewangan wrote:
>> use macro REGMAP_IRQ_REG from regmap.h to initialise the
>> regmap irq table for max77686.
> Why? Any benefits?
>
>
I think it is better coding to use macro for member initializations 
instead of doing it locally and it improves readability.

I got the similar comment from Lee's in my MFD patches to use macro for 
such initialization and I agreed with him.

As I was here on this driver, thought to use macro.