linux-kernel - Re: [PATCH] pcmcia: db1xxx: use correct irq_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60750044.6kqqL7c64M@wuerfel>
Date:	Wed, 02 Mar 2016 09:58:07 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Manuel Lauss <manuel.lauss@...il.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	linux-pcmcia <linux-pcmcia@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper

On Wednesday 02 March 2016 07:50:28 Manuel Lauss wrote:
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Cc: stable@...r.kernel.org # v4.3
> > Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> > ---
> > I think this is now the last holdout of the irq_to_gpio function,
> > and it's been broken for a while. Maybe Ralf can queue it up through
> > the MIPS tree along with the other fix for irq_to_gpio?
> 
> It's not broken though..  this driver on current linus-git works fine!

Ah, so it doesn't actually need the gpio line then?

irq_to_gpio() unconditionally returns -EINVAL since 4.3, so the easiest
fix would be to remove the card-detect function in the driver, right?

	Arnd