linux-kernel - Re: [PATCH] mm/compaction: don't use modular references for non modular code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56D6B0EC.2010601@suse.cz>
Date:	Wed, 2 Mar 2016 10:22:52 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org
Cc:	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm/compaction: don't use modular references for non
 modular code

On 02/13/2016 11:47 PM, Paul Gortmaker wrote:
> replace module_init with subsys_initcall ; which will be two
> levels earlier, but mm smells like a subsystem to me.

I admit I don't know the exact differences here, but it makes sense as 
it's not a module.
I just copied this code from kswapd, which also uses module_init(). 
Should it be also converted?

> Compile tested only.
>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>
> [Feel free to squash this into the original, if desired.]
>
>   mm/compaction.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 4cb1c2ef5abb..4d99e1f5055c 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -20,7 +20,6 @@
>   #include <linux/kasan.h>
>   #include <linux/kthread.h>
>   #include <linux/freezer.h>
> -#include <linux/module.h>
>   #include "internal.h"
>
>   #ifdef CONFIG_COMPACTION
> @@ -1954,7 +1953,6 @@ static int __init kcompactd_init(void)
>   	hotcpu_notifier(cpu_callback, 0);
>   	return 0;
>   }
> -
> -module_init(kcompactd_init)
> +subsys_initcall(kcompactd_init)
>
>   #endif /* CONFIG_COMPACTION */
>