linux-kernel - Re: [PATCH] clk: qcom: msm8960: Fix ce3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56D6B3FC.4040709@linaro.org>
Date:	Wed, 2 Mar 2016 09:35:56 +0000
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>,
	Michael Turquette <mturquette@...libre.com>
Cc:	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH] clk: qcom: msm8960: Fix ce3_src register offset



On 02/03/16 01:30, Stephen Boyd wrote:
> The offset seems to have been copied from the sata clk. Fix it so
> that enabling the crypto engine source clk works.
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Tested-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Fixes: 5f775498bdc4 ("clk: qcom: Fully support apq8064 global clock control")
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---

Good find :-)

Tested-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

>   drivers/clk/qcom/gcc-msm8960.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c
> index 63ecd97f3793..0a0c1f533249 100644
> --- a/drivers/clk/qcom/gcc-msm8960.c
> +++ b/drivers/clk/qcom/gcc-msm8960.c
> @@ -2753,7 +2753,7 @@ static struct clk_rcg ce3_src = {
>   	},
>   	.freq_tbl = clk_tbl_ce3,
>   	.clkr = {
> -		.enable_reg = 0x2c08,
> +		.enable_reg = 0x36c0,
>   		.enable_mask = BIT(7),
>   		.hw.init = &(struct clk_init_data){
>   			.name = "ce3_src",
>