linux-kernel - Re: [RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201603021728.bH7l6QS7%fengguang.wu@intel.com>
Date:	Wed, 2 Mar 2016 17:50:12 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	Sameer Nanda <snanda@...omium.org>,
	Javier Martinez Canillas <javier@....samsung.com>,
	Lee Jones <lee.jones@...aro.org>,
	Benson Leung <bleung@...omium.org>,
	Enric Balletbò 
	<enric.balletbo@...labora.co.uk>,
	Vic Yang <victoryang@...omium.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Vincent Palatin <vpalatin@...omium.org>,
	Randall Spangler <rspangler@...omium.org>,
	Todd Broch <tbroch@...omium.org>,
	Gwendal Grignou <gwendal@...omium.org>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Shawn Nematbakhsh <shawnn@...omium.org>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	linux-pm@...r.kernel.org, David Woodhouse <dwmw2@...radead.org>
Subject: Re: [RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based
 USB PD charger driver

Hi Sameer,

[auto build test WARNING on v4.5-rc6]
[also build test WARNING on next-20160302]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Tomeu-Vizoso/EC-based-USB-Power-Delivery-support-for-Chrome-machines/20160302-163035
config: arm-exynos_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/power/cros_usbpd-charger.c: In function 'get_ec_usb_pd_power_info':
   drivers/power/cros_usbpd-charger.c:241:21: error: 'POWER_SUPPLY_TYPE_USB_PD_DRP' undeclared (first use in this function)
       port->psy_type = POWER_SUPPLY_TYPE_USB_PD_DRP;
                        ^
   drivers/power/cros_usbpd-charger.c:241:21: note: each undeclared identifier is reported only once for each function it appears in
   drivers/power/cros_usbpd-charger.c:249:20: error: 'POWER_SUPPLY_TYPE_USB_TYPE_C' undeclared (first use in this function)
      port->psy_type = POWER_SUPPLY_TYPE_USB_TYPE_C;
                       ^
   drivers/power/cros_usbpd-charger.c:261:21: error: 'POWER_SUPPLY_TYPE_USB_PD' undeclared (first use in this function)
       port->psy_type = POWER_SUPPLY_TYPE_USB_PD;
                        ^
   In file included from arch/arm/include/asm/div64.h:126:0,
                    from include/linux/kernel.h:136,
                    from include/linux/list.h:8,
                    from include/linux/preempt.h:10,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/ktime.h:24,
                    from drivers/power/cros_usbpd-charger.c:16:
   drivers/power/cros_usbpd-charger.c: In function 'cros_usb_pd_print_log_entry':
   include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast
     (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                               ^
>> drivers/power/cros_usbpd-charger.c:527:2: note: in expansion of macro 'do_div'
     do_div(msecs, MSEC_PER_SEC);
     ^

vim +/do_div +527 drivers/power/cros_usbpd-charger.c

   511				      MCDP_FAMILY(minfo->family),
   512				      MCDP_CHIPID(minfo->chipid),
   513				      minfo->irom.major, minfo->irom.minor,
   514				      minfo->irom.build, minfo->fw.major,
   515				      minfo->fw.minor, minfo->fw.build);
   516			break;
   517		default:
   518			APPEND_STRING(buf, len,
   519				"Event %02x (%04x) [", r->type, r->data);
   520			for (i = 0; i < PD_LOG_SIZE(r->size_port); i++)
   521				APPEND_STRING(buf, len, "%02x ", r->payload[i]);
   522			APPEND_STRING(buf, len, "]");
   523			break;
   524		}
   525	
   526		msecs = ktime_to_ms(tstamp);
 > 527		do_div(msecs, MSEC_PER_SEC);
   528		pr_info("PDLOG %d/%02d/%02d %02d:%02d:%02d.%03lld P%d %s\n",
   529			rt.tm_year + 1900, rt.tm_mon + 1, rt.tm_mday,
   530			rt.tm_hour, rt.tm_min, rt.tm_sec, msecs,
   531			PD_LOG_PORT(r->size_port), buf);
   532	}
   533	
   534	static void cros_usb_pd_log_check(struct work_struct *work)
   535	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (23863 bytes)