linux-kernel - [v2 PATCH 2/3] ipmi/watchdog: Use nmi_panic() when kernel panics in NMI handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160302103629.5058.60500.stgit@softrs>
Date:	Wed, 02 Mar 2016 19:36:29 +0900
From:	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Mingarelli <thomas.mingarelli@....com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Corey Minyard <minyard@....org>
Cc:	Corey Minyard <cminyard@...sta.com>,
	Michal Hocko <mhocko@...e.com>, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org, Michal Hocko <mhocko@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	openipmi-developer@...ts.sourceforge.net,
	Guenter Roeck <linux@...ck-us.net>
Subject: [v2 PATCH 2/3] ipmi/watchdog: Use nmi_panic() when kernel panics in
 NMI handler

commit 1717f2096b54 ("panic, x86: Fix re-entrance problem due to
panic on NMI") introduced nmi_panic() which prevents concurrent and
recursive execution of panic().  It also saves registers for the
crash dump on x86 by later commit 58c5661f2144 ("panic, x86: Allow
CPUs to save registers even if looping in NMI context").

ipmi_watchdog driver can call panic() from NMI handler, so replace
it with nmi_panic().

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
Acked-by: Corey Minyard <cminyard@...sta.com>
Acked-by: Guenter Roeck <linux@...ck-us.net>
Reviewed-by: Michal Hocko <mhocko@...e.com>
Cc: openipmi-developer@...ts.sourceforge.net
---
 drivers/char/ipmi/ipmi_watchdog.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 096f0ce..4facc75 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -1140,7 +1140,7 @@ ipmi_nmi(unsigned int val, struct pt_regs *regs)
 		   the timer.   So do so. */
 		pretimeout_since_last_heartbeat = 1;
 		if (atomic_inc_and_test(&preop_panic_excl))
-			panic(PFX "pre-timeout");
+			nmi_panic(regs, PFX "pre-timeout");
 	}
 
 	return NMI_HANDLED;