linux-kernel - Re: [tip:smp/hotplug] cpu/hotplug: Convert to a state machine for the control processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160302112315.GD6357@twins.programming.kicks-ass.net>
Date:	Wed, 2 Mar 2016 12:23:15 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	rusty@...tcorp.com.au, bigeasy@...utronix.de, rostedt@...dmis.org,
	oleg@...hat.com, tglx@...utronix.de, pjt@...gle.com,
	riel@...hat.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, arjan@...ux.intel.com, tj@...nel.org,
	srivatsa@....edu, akpm@...ux-foundation.org, mingo@...nel.org,
	hpa@...or.com, paulmck@...ux.vnet.ibm.com,
	rafael.j.wysocki@...el.com
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:smp/hotplug] cpu/hotplug: Convert to a state machine for
 the control processor

On Tue, Mar 01, 2016 at 11:53:25AM -0800, tip-bot for Thomas Gleixner wrote:
> @@ -558,22 +648,22 @@ static int _cpu_up(unsigned int cpu, int tasks_frozen)
>  
>  	cpuhp_tasks_frozen = tasks_frozen;
>  
> +	prev_state = st->state;
> +	st->target = CPUHP_ONLINE;
> +	while (st->state < st->target) {
> +		struct cpuhp_step *step;
> +
> +		st->state++;
> +		step = cpuhp_bp_states + st->state;
> +		ret = cpuhp_invoke_callback(cpu, st->state, step->startup);
> +		if (ret) {
> +			st->target = prev_state;
> +			undo_cpu_up(cpu, st);
> +			break;
> +		}
> +	}

All your other state loops use for().