linux-kernel - Re: [PATCH] perf tests: initialize sa.sa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160302125901.GF6356@twins.programming.kicks-ass.net>
Date:	Wed, 2 Mar 2016 13:59:01 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tests: initialize sa.sa_flags

On Wed, Mar 02, 2016 at 12:55:22PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The sa_flags field is not being initialized, so a garbage value is
> being passed to sigaction.  Initialize it to zero.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  tools/perf/arch/x86/tests/rdpmc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/arch/x86/tests/rdpmc.c b/tools/perf/arch/x86/tests/rdpmc.c
> index 7bb0d13..7945462 100644
> --- a/tools/perf/arch/x86/tests/rdpmc.c
> +++ b/tools/perf/arch/x86/tests/rdpmc.c
> @@ -103,6 +103,7 @@ static int __test__rdpmc(void)
>  
>  	sigfillset(&sa.sa_mask);
>  	sa.sa_sigaction = segfault_handler;
> +	sa.sa_flags = 0;

Would not something like:

	sa = (struct sigaction){
		.sa_sigaction = segfault_handler,
	};
	sigfillset(&sa.sa_mask);

Be better?

>  	sigaction(SIGSEGV, &sa, NULL);
>  
>  	fd = sys_perf_event_open(&attr, 0, -1, -1,
> -- 
> 2.7.0
>