linux-kernel - Re: [PATCH V3 2/4] net-next: mediatek: add support for MT7623 ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Mar 2016 13:06:55 -0800
From:	Joe Perches <joe@...ches.com>
To:	John Crispin <blogic@...nwrt.org>,
	"David S. Miller" <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Steven Liu (劉人豪) 
	<steven.liu@...iatek.com>,
	Carlos Huang (黃士彰) 
	<Carlos.Huang@...iatek.com>, Felix Fietkau <nbd@...nwrt.org>,
	Michael Lee <igvtee@...il.com>
Subject: Re: [PATCH V3 2/4] net-next: mediatek: add support for MT7623
 ethernet

On Thu, 2016-03-03 at 21:02 +0100, John Crispin wrote:
> Add ethernet support for MediaTek SoCs from the MT7623 family.
[]
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
[]
> +/* ugly macro hack to make sure hw_stats and ethtool strings are consistent */

I agree and think the _FE macros defines and uses should be removed.