linux-kernel - RE: [PATCH 4/4] MSR: msr Batch processing feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 23:09:17 +0000
From:	"Mcfadden, Marty Jay" <mcfadden8@...l.gov>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
CC:	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>, "bp@...en8.de" <bp@...en8.de>,
	"bp@...e.de" <bp@...e.de>, "brgerst@...il.com" <brgerst@...il.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"dyoung@...hat.com" <dyoung@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux@...izon.com" <linux@...izon.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"luto@...nel.org" <luto@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"pavel@....cz" <pavel@....cz>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"x86@...nel.org" <x86@...nel.org>,
	"yu.c.chen@...el.com" <yu.c.chen@...el.com>
Subject: RE: [PATCH 4/4] MSR: msr Batch processing feature

> From: One Thousand Gnomes [mailto:gnomes@...rguk.ukuu.org.uk]
> Sent: Thursday, March 03, 2016 9:21 AM
> 
> That strikes me as a very bad idea btw. If your opener was privileged and leaks
> the handle via exec or anything else to another process that process inherits the
> powers which means it can own the system trivially.
> 

Agreed, definitely a bad idea on my part.  I will revert these particular changes.

> 
> So a user can fill your log because you have lots of pr_err() calls etc

Thanks, I will scrub out the unnecessary pr_err() calls.

> > +	err = msrbatch_apply_whitelist(&koa, myinfo);
> 
> Two threads doing this at once will break if they issue overlapping
> requests with and/or (plus whatever carnage if you clash with 
> any other kernel used MSR)

Good point.  I'll add protection around the whitelist.

Thank you for your review and comments,

Marty