linux-kernel - Re: [PATCH 3/4] leds: Add driver for the ISSI IS31FL32xx family of LED controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 11:21:00 +0800
From:	kbuild test robot <lkp@...el.com>
To:	"David Rivshin (Allworx)" <drivshin.allworx@...il.com>
Cc:	kbuild-all@...org, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Stefan Wahren <stefan.wahren@...e.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] leds: Add driver for the ISSI IS31FL32xx family of
 LED controllers

Hi David,

[auto build test WARNING on j.anaszewski-leds/for-next]
[also build test WARNING on next-20160302]
[cannot apply to v4.5-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/David-Rivshin-Allworx/leds-Add-driver-for-the-ISSI-IS31FL32xx-family-of-LED-controllers/20160303-110656
base:   https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds for-next
config: sparc64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   drivers/leds/leds-is31fl32xx.c: In function 'is31fl32xx_parse_child_dt':
>> drivers/leds/leds-is31fl32xx.c:344:6: warning: passing argument 1 of 'of_property_read_string' discards 'const' qualifier from pointer target type
     if (of_property_read_string(child, "label", &cdev->name))
         ^
   In file included from arch/sparc/include/asm/openprom.h:14:0,
                    from arch/sparc/include/asm/device.h:9,
                    from include/linux/device.h:30,
                    from include/linux/i2c.h:30,
                    from drivers/leds/leds-is31fl32xx.c:17:
   include/linux/of.h:299:12: note: expected 'struct device_node *' but argument is of type 'const struct device_node *'
    extern int of_property_read_string(struct device_node *np,
               ^
   drivers/leds/leds-is31fl32xx.c:356:2: warning: passing argument 1 of 'of_property_read_string' discards 'const' qualifier from pointer target type
     of_property_read_string(child, "linux,default-trigger",
     ^
   In file included from arch/sparc/include/asm/openprom.h:14:0,
                    from arch/sparc/include/asm/device.h:9,
                    from include/linux/device.h:30,
                    from include/linux/i2c.h:30,
                    from drivers/leds/leds-is31fl32xx.c:17:
   include/linux/of.h:299:12: note: expected 'struct device_node *' but argument is of type 'const struct device_node *'
    extern int of_property_read_string(struct device_node *np,
               ^

vim +344 drivers/leds/leds-is31fl32xx.c

   328	}
   329	
   330	static inline size_t sizeof_is31fl32xx_priv(int num_leds)
   331	{
   332		return sizeof(struct is31fl32xx_priv) +
   333			      (sizeof(struct is31fl32xx_led_data) * num_leds);
   334	}
   335	
   336	static int is31fl32xx_parse_child_dt(const struct device *dev,
   337					     const struct device_node *child,
   338					     struct is31fl32xx_led_data *led_data)
   339	{
   340		struct led_classdev *cdev = &led_data->cdev;
   341		int ret = 0;
   342		u32 reg;
   343	
 > 344		if (of_property_read_string(child, "label", &cdev->name))
   345			cdev->name = child->name;
   346	
   347		ret = of_property_read_u32(child, "reg", &reg);
   348		if (ret || reg < 1 || reg > led_data->priv->cdef->channels) {
   349			dev_err(dev,
   350				"Child node %s does not have a valid reg property\n",
   351				child->full_name);
   352			return -EINVAL;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (45112 bytes)