linux-kernel - Re: [PATCH v2] dax: check return value of dax_radix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 14:49:11 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Ross Zwisler <ross.zwisler@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	linux-nvdimm@...ts.01.org
Subject: Re: [PATCH v2] dax: check return value of dax_radix_entry()

On Wed, Mar 02, 2016 at 10:00:51AM -0700, Ross Zwisler wrote:
> dax_pfn_mkwrite() previously wasn't checking the return value of the call
> to dax_radix_entry(), which was a mistake.
> 
> Instead, capture this return value and return the appropriate VM_FAULT_
> value.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

Hi Ross,

Can you please cc dax stuff to linux-fsdevel? it is way too easy to
miss stuff like this when lkml is the only list it's sent to?

That said, the change looks good.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com