lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Thu, 3 Mar 2016 17:36:54 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Minchan Kim <minchan@...nel.org>, mm-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org, sergey.senozhatsky@...il.com,
	sergey.senozhatsky.work@...il.com
Subject: Re: + mm-zsmalloc-add-freeable-column-to-pool-stat.patch added to
 -mm tree

On (02/29/16 15:12), akpm@...ux-foundation.org wrote:
[..]
>  	seq_puts(s, "\n");
> -	seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu\n",
> +	seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %7lu\n",
>  			"Total", "", total_class_almost_full,
>  			total_class_almost_empty, total_objs,
> -			total_used_objs, total_pages);
> +			total_used_objs, total_pages, "", total_freeable);

Andrew, may I please ask you to add the following small -fix patch?

looks like I failed to squash patches on my side properly and
`total_freeable' is not exactly aligned with the `freeable'
column name (off by one char %7 -> %8).

---

 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 1023e0d..d43f68e 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -556,7 +556,7 @@ static int zs_stats_size_show(struct seq_file *s, void *v)
 	}
 
 	seq_puts(s, "\n");
-	seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %7lu\n",
+	seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %8lu\n",
 			"Total", "", total_class_almost_full,
 			total_class_almost_empty, total_objs,
 			total_used_objs, total_pages, "", total_freeable);

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ