linux-kernel - Re: [PATCH v2] thermal: Fix build error of missing devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 12:58:27 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Linux PM list <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Krzysztof Kozlowski <k.kozlowski.k@...il.com>
Subject: Re: [PATCH v2] thermal: Fix build error of missing
 devm_ioremap_resource on UM

Hi Krzysztof,

On Thu, Mar 3, 2016 at 12:49 PM, Krzysztof Kozlowski
<k.kozlowski@...sung.com> wrote:
> 2016-03-03 18:01 GMT+09:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
>> On Thu, Mar 3, 2016 at 9:44 AM, Krzysztof Kozlowski
>> <k.kozlowski@...sung.com> wrote:
>> > --- a/drivers/thermal/Kconfig
>> > +++ b/drivers/thermal/Kconfig
>> > @@ -177,7 +177,7 @@ config THERMAL_EMULATION
>> >
>> >  config HISI_THERMAL
>> >         tristate "Hisilicon thermal driver"
>> > -       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
>> > +       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST && HAS_IOMEM
>>
>> I think these are easier to read and maintain if you split hard and soft
>> dependencies, e.g.
>>
>>         depends on HAS_IOMEM
>>         depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
>
> Indeed this looks more readable but the HAS_IOMEM becomes a missing
> dependency only for COMPILE_TEST. Usually it is included in the
> architecture.

HAS_IOMEM is still a dependency, but it's implied by ARCH_HISI.
COMPILE_TEST allows to discover more dependencies, and document them.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds