[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160303130424.GP6356@twins.programming.kicks-ass.net>
Date: Thu, 3 Mar 2016 14:04:24 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Juri Lelli <juri.lelli@....com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Linux PM list <linux-pm@...r.kernel.org>,
Steve Muckle <steve.muckle@...aro.org>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Viresh Kumar <viresh.kumar@...aro.org>,
Vincent Guittot <vincent.guittot@...aro.org>,
Michael Turquette <mturquette@...libre.com>
Subject: Re: [PATCH 1/6] cpufreq: Reduce cpufreq_update_util() overhead a bit
On Thu, Mar 03, 2016 at 11:47:01AM +0000, Juri Lelli wrote:
> > +#ifdef CONFIG_LOCKDEP
> > + WARN_ON(debug_locks && !rcu_read_lock_sched_held());
> > +#endif
> >
> > data = rcu_dereference(*this_cpu_ptr(&cpufreq_update_util_data));
>
> I think you need to s/rcu_dereference/rcu_dereference_sched/ here or
> RCU will complain:
Ah, indeed ;-)
Powered by blists - more mailing lists