linux-kernel - Re: [PATCH 08/27] mm, vmscan: Make kswapd reclaim in terms of nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 14:46:14 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Mel Gorman <mgorman@...hsingularity.net>,
	Linux-MM <linux-mm@...ck.org>
Cc:	Rik van Riel <riel@...riel.com>,
	Johannes Weiner <hannes@...xchg.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/27] mm, vmscan: Make kswapd reclaim in terms of nodes

On 02/23/2016 04:04 PM, Mel Gorman wrote:
> -static bool zone_balanced(struct zone *zone, int order, bool highorder,
> +static bool zone_balanced(struct zone *zone, int order,
>  			unsigned long balance_gap, int classzone_idx)
>  {
>  	unsigned long mark = high_wmark_pages(zone) + balance_gap;
>  
> -	/*
> -	 * When checking from pgdat_balanced(), kswapd should stop and sleep
> -	 * when it reaches the high order-0 watermark and let kcompactd take
> -	 * over. Other callers such as wakeup_kswapd() want to determine the
> -	 * true high-order watermark.
> -	 */
> -	if (IS_ENABLED(CONFIG_COMPACTION) && !highorder) {
> -		mark += (1UL << order);
> -		order = 0;
> -	}
> -
>  	return zone_watermark_ok_safe(zone, order, mark, classzone_idx);

Did you really intend to remove this or was it due to rebasing on top of
kcompactd?
My intention was that kswapd will consider zone balanced just by having
enough base pages. Maybe the next patches will reintroduce this differently?