linux-kernel - Re: [PATCH] net: eth: altera: do not free array priv->mdio->irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 16:16:31 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Colin King <colin.king@...onical.com>
Cc:	Vince Bridgers <vbridger@...nsource.altera.com>,
	netdev@...r.kernel.org, nios2-dev@...ts.rocketboards.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: eth: altera: do not free array priv->mdio->irq

On Thu, Mar 03, 2016 at 01:47:18PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
> 
> Issue detected using static analysis with CoverityScan
> 
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks
	Andrew

> ---
>  drivers/net/ethernet/altera/altera_tse_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 1747285..f749e4d 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -193,7 +193,6 @@ static void altera_tse_mdio_destroy(struct net_device *dev)
>  			    priv->mdio->id);
>  
>  	mdiobus_unregister(priv->mdio);
> -	kfree(priv->mdio->irq);
>  	mdiobus_free(priv->mdio);
>  	priv->mdio = NULL;
>  }
> -- 
> 2.7.0
>