linux-kernel - Re: [PATCH v4 5/6] dt/bindings: rockchip: modify document of Rockchip power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 02 Mar 2016 16:19:12 -0800
From:	Kevin Hilman <khilman@...libre.com>
To:	Elaine Zhang <zhangqing@...k-chips.com>
Cc:	heiko@...ech.de, wxt@...k-chips.com,
	linux-arm-kernel@...ts.infradead.org, huangtao@...k-chips.com,
	zyw@...k-chips.com, xxx@...k-chips.com, jay.xu@...k-chips.com,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/6] dt/bindings: rockchip: modify document of Rockchip power domains

Elaine Zhang <zhangqing@...k-chips.com> writes:

> Add binding documentation for the power domains
> found on Rockchip RK3399 SoCs
>
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>

Acked-by: Kevin Hilman <khilman@...libre.com>

For the general approach for adding sub-domains, but some minor nits below...

> ---
>  .../bindings/soc/rockchip/power_domain.txt         | 41 ++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> index 13dc6a3..9eb43fa 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> @@ -7,6 +7,7 @@ Required properties for power domain controller:
>  - compatible: Should be one of the following.
>  	"rockchip,rk3288-power-controller" - for RK3288 SoCs.
>  	"rockchip,rk3368-power-controller" - for RK3368 SoCs.
> +	"rockchip,rk3399-power-controller" - for RK3399 SoCs.
>  - #power-domain-cells: Number of cells in a power-domain specifier.
>  	Should be 1 for multiple PM domains.
>  - #address-cells: Should be 1.
> @@ -16,6 +17,7 @@ Required properties for power domain sub nodes:
>  - reg: index of the power domain, should use macros in:
>  	"include/dt-bindings/power/rk3288-power.h" - for RK3288 type power domain.
>  	"include/dt-bindings/power/rk3368-power.h" - for RK3368 type power domain.
> +	"include/dt-bindings/power/rk3399-power.h" - for RK3399 type power domain.
>  - clocks (optional): phandles to clocks which need to be enabled while power domain
>  	switches state.
>  
> @@ -45,12 +47,45 @@ Example:
>                  };
>          };
>  
> +Example 2:
> +
> +	power: power-controller {
> +		compatible = "rockchip,rk3399-power-controller";
> +		#power-domain-cells = <1>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		/*parent domain*/

please fix up the comment style in these examples (here and below) since they will likely
be copy/pasted into a real DT.

> +		pd_vio {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <RK3399_PD_VIO>;
> +
> +			/*child domain of pd_vio*/
> +			pd_vo {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				reg = <RK3399_PD_VO>;
> +
> +				/*child domain of pd_vo*/
> +				pd_vopb {
> +					reg = <RK3399_PD_VOPB>;
> +				};
> +
> +				pd_vopl {
> +					reg = <RK3399_PD_VOPL>;
> +				};
> +			};
> +		};
> +	};
> +

Kevin