linux-kernel - Re: [PATCH v4 0/4] add reboot mode driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 09:52:49 +0800
From:	Caesar Wang <caesar.upstream@...il.com>
To:	Andy Yan <andy.yan@...k-chips.com>
Cc:	robh+dt@...nel.org, john.stultz@...aro.org, arnd@...db.de,
	heiko@...ech.de, mark.rutland@....com, catalin.marinas@....com,
	will.deacon@....com, sre@...nel.org,
	alexandre.belloni@...e-electrons.com, f.fainelli@...il.com,
	linux@....linux.org.uk, dbaryshkov@...il.com, richard@....at,
	linux-rockchip@...ts.infradead.org, wxt@...k-chips.com,
	devicetree@...r.kernel.org, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, edubezval@...il.com,
	lorenzo.pieralisi@....com, matthias.bgg@...il.com,
	moritz.fischer@...us.com, linux-kernel@...r.kernel.org,
	galak@...eaurora.org, olof@...om.net, jun.nie@...aro.org,
	dwmw2@...radead.org
Subject: Re: [PATCH v4 0/4] add reboot mode driver

Hi Andy,


This series patches ware verified on my github with RK3368 evb and 
RK30236 board.
https://github.com/Caesar-github/rockchip/tree/for-reboot-mode-tests


在 2016年03月01日 20:09, Andy Yan 写道:
> This driver parse the reboot commands like "reboot loader"
> and "reboot recovery" to get a boot mode described in the
> device tree , then call the corresponding  write interfae
> to store the boot mode in some place like special register
> or ram , which can be read by the bootloader after system
> reboot.
>
> This is commonly done on Android based devices, in order to
> reboot the device into fastboot or recovery mode.
>
>
> Changes in v4:
> - remove mode-maskrom
> - rename mode-fastboot to mode-bootloader to keep compatible with the exiting Android device
> - make this driver depends on OF to avoid kbuild test error
>
> Changes in v3:
> - descirbe all reboot mode as properity instead of subnode
> - scan multi properities
> - add mask value for some platform which only use some bits of the register
>    to store boot mode magic value
> - descirbe all reboot mode as property instead of subnode
> - add rk3036 support
> - descirbe all reboot mode as properity instead of subnode
>
> Changes in v2:
> - move to dir drivers/power/reset/
> - make syscon-reboot-mode a generic driver
> - make this node as a subnode of PMU
> - make this node as a subnode of pmugrf
>
> Changes in v1:
> - fix the embarrassed compile warning
> - correct the maskrom magic number
> - check for the normal reboot
> - correct the maskrom magic number
> - use macro defined in rockchip_boot-mode.h for reboot-mode DT node
>
> Andy Yan (4):
>    dt-bindings: power: reset: add document for reboot-mode driver
>    power: reset: add reboot mode driver
>    ARM: dts: rockchip: add syscon-reboot-mode DT node
>    ARM64: dts: rockchip: add syscon-reboot-mode DT node

Tested-by: Caesar Wang <wxt@...k-chips.com>


>
>   .../bindings/power/reset/reboot-mode.txt           |  24 +++++
>   .../bindings/power/reset/syscon-reboot-mode.txt    |  35 +++++++
>   arch/arm/boot/dts/rk3036.dtsi                      |  11 ++-
>   arch/arm/boot/dts/rk3288.dtsi                      |  10 ++
>   arch/arm/boot/dts/rk3xxx.dtsi                      |  12 ++-
>   arch/arm64/boot/dts/rockchip/rk3368.dtsi           |  13 ++-
>   drivers/power/reset/Kconfig                        |  16 ++++
>   drivers/power/reset/Makefile                       |   2 +
>   drivers/power/reset/reboot-mode.c                  | 105 +++++++++++++++++++++
>   drivers/power/reset/reboot-mode.h                  |   6 ++
>   drivers/power/reset/syscon-reboot-mode.c           |  64 +++++++++++++
>   include/dt-bindings/soc/rockchip_boot-mode.h       |  30 ++++++
>   12 files changed, 325 insertions(+), 3 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/power/reset/reboot-mode.txt
>   create mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt
>   create mode 100644 drivers/power/reset/reboot-mode.c
>   create mode 100644 drivers/power/reset/reboot-mode.h
>   create mode 100644 drivers/power/reset/syscon-reboot-mode.c
>   create mode 100644 include/dt-bindings/soc/rockchip_boot-mode.h
>


-- 
Thanks,
Caesar